sarbbottam / eslint-find-rules

Find built-in ESLint rules you don't have in your custom config

http://npm.im/eslint-find-rules

MIT License

201 stars 33 forks source link

chore: update babel and eslint to support es2017 #340

Closed PaperStrike closed 2 years ago

PaperStrike commented 2 years ago

Resolve https://github.com/MichaelDeBoey/eslint-find-rules/pull/13#discussion_r744166294

Switch to use babel-preset-env, since babel-preset-es2015 has been deprecated and the former supports es2017 and more configurations
Exclude transform-regenerator in babel config since transform-regenerator requires a runtime polyfill and isn't actually needed if we don't use Generator.prototype.return()
Update eslint target ecma version to 2017

ljharb commented 2 years ago

hmm, it's very strange - you have the "allow edits" box checked, and this PR's fork is your own, but for some reason I can't force push to it.

If you could squash the second one into the first one, that'd be great.

PaperStrike commented 2 years ago

squashed! 😀

codecov-commenter commented 2 years ago

Codecov Report

Merging #340 (6b4b5a0) into master (bc91e07) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          181       181           
=========================================
  Hits           181       181

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc91e07...6b4b5a0. Read the comment docs.