search

sarbian / ModuleManager

176 stars 96 forks source link

ModuleManager.log filepath #164

Closed Aquilux closed 3 years ago

Aquilux commented 3 years ago

Upon loading and seeing some warnings and errors generated by MM, I decided to see if I could find the log output for those errors. But unfortunately the directory in which the log file should have been did not exist. When reviewing the log entry containing the directory I found this: [LOG 14:56:04.362] [ModuleManager] Patching started on a new thread, all output will be directed to C:/Kerbal Space Program/ksp 1.10.1 moded/KSP_x64_Data/../Logs\ModuleManager\ModuleManager.log

The log file appears as though it is not being generated due to the use of backslashes instead of forward slashes in the file path.

Aquilux commented 3 years ago

MMissue1 MMissue2 MMissue3 MMissue4

sarbian commented 3 years ago

Unity does not differentiate between backward and forward slash. The only place you did not share a screenshot of is where the KSP exe is, which is also where the log should be.

Aquilux commented 3 years ago

My apologies. I thought the log file should be in the directory that module manager indicated in the main KSP log. On re-inspection I have found the module manager log embedded in the main KSP log, though there is no "ModuleManager.log" file in my KSP dir.

MMissue5

blowfishpro commented 3 years ago

ModuleManager.log exists in <ksp_root>/Logs/ModuleManager/. Its contents are also copied to the main log for convienience.

Aquilux commented 3 years ago

Ah, my apologies then. I was just confused as that is not the path stated near the beginning of the main KSP log. I was expecting C:/Kerbal Space Program/ksp 1.10.1 moded/KSP_x64_Data/. . . /Logs/ModuleManager/ModuleManager.log as indicated in the main log, not C:/Kerbal Space Program/ksp 1.10.1 moded/Logs/ModuleManager/ModuleManager.log

As the file is generated my major concern is alleviated, but the filepath for the log as indicated in the main KSP log still does not match it's actual location and while this is a low level concern, it should probably be fixed eventually to prevent future confusion.

blowfishpro commented 3 years ago

The path is valid and correct - .. in a path means going up a level. But it is confusing and difficult to read. Thank KSP for generating its own root path this way and not normalizing it. Maybe ModuleManager can normalize the path.

Aquilux commented 3 years ago

Oh... That's ..... odd. The way I was reading that was it cutting excessive length out of the file path. I don't think I've ever seen that particular notation in an informative note before.