sarbian / ModuleManager

176 stars 96 forks source link

Fix off-by-one string indexing in constraint checking #171

Closed al2me6 closed 2 years ago

al2me6 commented 2 years ago

Fixes #170, #172.

Also change string comparison type to StringComparison.Ordinal, which should be the correct type according to https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings.

Bornholio commented 2 years ago

This should also close #172

al2me6 commented 2 years ago

I'm actually going to remove the string comparison change for now and send in a separate PR since there's more instances of culture-dependent comparisons.

sarbian commented 2 years ago

Thanks.