search

sarbian / SmokeScreen

BSD 2-Clause "Simplified" License
16 stars 14 forks source link

localPosition and offset ignore scaling? #16

Open MOARdV opened 9 years ago

MOARdV commented 9 years ago

As the title says - particularly, scaling in the model, not necessarily scaling from a MODEL node in the config. For an example case, I've posted a MM SmokeScreen config for the KOSMOS RD-33NK engine on DropBox. I've included the engine in the .zip for reference. Note that localPosition in the override is set to 0, 0, -50, but the flame appears pretty close to the end of the bell, not 50 meters away.

I discovered the scaling when working on a plugin of my own that tweaks some of the KOSMOS models. I think the model's root.localScale is about 0.0254. Regardless, because of the scaling, localPosition and offset are not in units of meters for this engine.

sarbian commented 9 years ago

offset should react to the fixedScale of the effect. localPosition is not scaled at all. I can't remember if it's a choice or if I just forgot to scale it.

MOARdV commented 9 years ago

Okay - I may have been mistaken about offset. It'd be nice if localPosition accounted for scaling. It would have saved me some banging my head on the desk trying to figure out why I couldn't move the exhaust effects. :)