search

sarbian / SmokeScreen

BSD 2-Clause "Simplified" License
16 stars 14 forks source link

Effects not showing on physicsless parts #25

Open DerpyFirework opened 8 years ago

DerpyFirework commented 8 years ago

After trying to make RealPlume configs for certain engines, I noticed some parts won't show effects applied with SmokeScreen. After a few experiments, I found that parts with PhysicsSignificance = 1 in there configs will not show effects at all.

DerpyFirework commented 8 years ago

Just looked in the SmokeScreen code, it seems it prevents particles when there is no rigidbody, which explains the problem. In these cases, would it be possible to use the parent parts' rigidbody instead?

sarbian commented 8 years ago

I am not seeing it after a quick scan of the code. Can you point me to that rigibody test and I ll see how many change it require.

DerpyFirework commented 8 years ago

https://github.com/sarbian/SmokeScreen/blob/master/ModelMultiParticlePersistFX.cs#L266

DerpyFirework commented 8 years ago

I've just done some testing with the modifications above, and the numbers returned in a simple test were identical to the numbers produced with the current method. Not saying that this is the solution, as there are likely issues somewhere, but plumes now show on physicsless parts

sarbian commented 8 years ago

physicsless parts should not be used at all except for some really specific cases. I am not adding a change that promote miss use of the part config.

Edit : and a physic less engine is wrong on so many point...

DerpyFirework commented 8 years ago

Okay then, I'll see about resolving this on RealPlumes end then, by removing the PhysicsSignificance line. Thanks anyway!