search

sargon / ddhcpd

A distributed DHCP Daemon
GNU General Public License v3.0
31 stars 12 forks source link

Allow setting loglevel via socket or command line switch #57

Open christf opened 5 years ago

christf commented 5 years ago

setting loglevel via compile-option is inconvenient as it forces the decision on the person building the firmware whether everyone using the resulting images will be a developer. At the same time it is hampering analysis in images that were not built with verbose debug log in case a ddhcpd issue arises.

Being able to adjust the loglevel would help.

rubo77 commented 5 years ago

the reason to set this during build is that if you don't need the Log level it should not be built in because it would result in a much larger executable

christf commented 5 years ago

On Sun, Sep 08, 2019 at 11:39:30AM -0700, Ruben Barkow wrote:

the reason to set this during build is that if you don't need the Log level it should not be built in because it would result in a much larger executable That is ok. It is still inconvenient if there is no way to silence the daemon. At least for now (the ddhcpd package for openwrt sets the loglevel to 20) we are not using the space-saving feature.

How much does it save anyway?

-- () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments

sargon commented 5 years ago

It safes around 20k with the right settings. Updated the README to the changes in the logging implementation. The openwrt package sets it that way, because we are using it in a testbed in that way and we are kind of lazy ;)