search

sargon / trayer-srg

trayer fork with multi monitor support, cleaned up codebase and other fancy stuff
Other
223 stars 34 forks source link

wrong values for _NET_WM_STRUT_PARTIAL #2

Closed jpsecher closed 13 years ago

jpsecher commented 13 years ago

Please see http://bugs.debian.org/623429. If you want to reply directly to that bug report, use 623429@bugs.debian.org . And maybe http://bugs.debian.org/603447 is part of the same thing?

Cheers, Jens Peter Secher jps@debian.org

sargon commented 13 years ago

Hi,

I am currently at easterhegg and hacking some other stuff. I will have a look at it when I am back home. Thanks for the hint.

regards Daniel

dstu commented 13 years ago

I am having an issue similar to this one: when I start trayer in xmonad with --SetPartialStrut true, xmonad does not properly avoid covering trayer. Instead, the following behavior is observed:

It looks like there is a problem with the call made to XChangeProperty at panel.c:panel_set_wm_struct. Per XGetWindowProperty(3):

If the specified format is 8, the property data must be a char array.  If the specified format is 16, the prop‐
erty data must be a short array.  If the specified format is 32, the property data must be a long array.

However, the type of data is unsigned int. Changing it to unsigned long fixes this issue for me.

sargon commented 13 years ago

dstu reply@reply.github.com schrieb:

I am having an issue similar to this one: when I start trayer in xmonad with --SetPartialStrut true, xmonad does not properly avoid covering trayer. Instead, the following behavior is observed:

  • If no --edge parameter is given, xmonad places windows on top of trayer.
  • If --edge left is specified, behavior is as expected.
  • If --edge right is specified, xmonad places windows on top of trayer.
  • If --edge top is specified, xmonad places windows on top of trayer but acts as though trayer is present on the right side. (It leaves an empty band of space on the right.)
  • If --edge bottom is specified, xmonad places windows on top of trayer.

It looks like there is a problem with the call made to XChangeProperty at panel.c:panel_set_wm_struct. Per XGetWindowProperty(3):

If the specified format is 8, the property data must be a char array. If the specified format is 16, the prop‐ erty data must be a short array. If the specified format is 32, the property data must be a long array.

However, the type of data is unsigned int. Changing it to unsigned long fixes this issue for me.

Reply to this email directly or view it on GitHub: https://github.com/sargon/trayer-srg/issues/2#issuecomment-1472181

Interisting, I will have a look at this in the beginning of the next week. Maybe I could reproduce this behaivour with this additional information.