search

sargue / mailgun

Java library to easily send emails using the Mailgun service
MIT License
153 stars 40 forks source link

Feature html color #15

Closed jlannoy closed 7 years ago

jlannoy commented 7 years ago

It was noticed it in the comment of the private tag() method, but not really possible to do. Now it is ;)

jlannoy commented 7 years ago

Sorry, I duplicated the param but forgot to change it... Done.

sargue commented 7 years ago

I'm having a second though about this. Reviewing the Builder class I see there is no other method like the one you propose. It seems a bit ad-hoc to me.

Maybe a better solution would be just to make the tag method public.

sargue commented 7 years ago

I'm publishing the tag method. See this: https://github.com/sargue/mailgun/wiki/Mail-content-using-content-helpers#low-level-html

Do you think that's enough?

jlannoy commented 7 years ago

I completely agree with you. I didn't want to break the public/private scope of your methods but it's more efficient in this way.

Thank you.

sargue commented 7 years ago

Great. I'm closing this PR and publishing a new version.