search

sariabod / codeacademy

intro to data analysis
1 stars 0 forks source link

Suggestion: Use Comments #1

Open Caealana opened 6 years ago

Caealana commented 6 years ago

https://github.com/sariabod/codeacademy/blob/56a6d84f2cf3145213a25ec3a9fd028c7b33f216/musclehub_project/musclehub.py#L24

Use comments liberally to describe what each code chunk is trying to accomplish. This will help future readers to more easily understand your code and critique it.

Also, how did you get the solutions to this project?

sariabod commented 6 years ago

@Caealana I do not understand the question about the solution. Do you mean how did I come up with the solution or literally, how did I get the solution jupyter notebook?

I worked out the solutions with help from google, the solution notebook was provided in the download. Are we not supposed to have that?

I will add more comments in the future.

Caealana commented 6 years ago

Haha, I meant the solution notebook. Yeah, I don't think the students are supposed to be given the solution notebook. I'll check with Codecademy.

On Tue, Feb 6, 2018 at 11:38 AM, Sam Ariabod notifications@github.com wrote:

@Caealana https://github.com/caealana I do not understand the question about the solution. Do you mean how did I come up with the solution or literally, how did I get the solution jupyter notebook?

I worked out the solutions with help from google, the solution notebook was provided in the download. Are we not supposed to have that?

I will add more comments in the future.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sariabod/codeacademy/issues/1#issuecomment-363482807, or mute the thread https://github.com/notifications/unsubscribe-auth/ANWj4JL3Ek-23heFdmZ9OMA2j4qQ1f5Xks5tSIAMgaJpZM4R7WAY .

sariabod commented 6 years ago

@Caealana ok, I will remove it from the repo in the meantime.

Caealana commented 6 years ago

Thanks!

On Tue, Feb 6, 2018 at 11:42 AM, Sam Ariabod notifications@github.com wrote:

@Caealana https://github.com/caealana ok, I will remove it from the repo in the meantime.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sariabod/codeacademy/issues/1#issuecomment-363484231, or mute the thread https://github.com/notifications/unsubscribe-auth/ANWj4Dj9r_2PXqAPHpVnzBmCS9j1Rv7Cks5tSIDdgaJpZM4R7WAY .