search

sarins / hudson-eclipse

Automatically exported from code.google.com/p/hudson-eclipse
0 stars 0 forks source link

Browser view doesn't work in Eclipse 3.4 #19

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Either double-click or select menu item "Open in Browser" for a Hudson
job item

What is the expected output? What do you see instead?
The expected output is a browser window containing the Hudson job display.
Instead the browser window remains empty.

What version of the product are you using? On what operating system?
version 1.04
Problem occurs on both Windows XP and Mac OS X

Please provide any additional information below.

Browser displays correctly for Windows XP and Mac OS X with Eclipse 3.3.2

Original issue reported on code.google.com by pat.pode...@gmail.com on 4 Jul 2008 at 3:48

GoogleCodeExporter commented 8 years ago 
Well, I experienced the same issue. I looked at the code and the main issue is 
that
the EditorInput works with Path (resp IPath) that is used for path names of 
files and
not for urls. According to the JavaDoc of org.eclipse.core.runtime.Path "The 
string
path must represent a valid file system path on the local file system. The path 
is
canonicalized and double slashes are removed except at the beginning. (to 
handle UNC
paths)."

The best would be not using Path for urls, but that would be a big change. So, I
added a simple fix that replaces any ":/" with "://" in the url before letting 
the
browser load it. Well, it's a quick hack, but it seems to work reliably. 

--> see attachment: SVN diff patch for HudsonBrowser.java

Original comment by flytol...@gmail.com on 30 Oct 2008 at 4:16

Attachments:

GoogleCodeExporter commented 8 years ago 
Patch applied, thanks

Original comment by jre...@gmail.com on 7 Apr 2009 at 4:18