saritasa-nest / saritasa-devops-helm-charts

Various helm charts
0 stars 0 forks source link

[tekton-pipelines]: detect-nodejs-version task doesn't handle node_version #54

Closed roman-mightydevops closed 1 year ago

roman-mightydevops commented 1 year ago

Currenly detect-nodejs-version task doesn't work if there are more than 1 node version specified in package.json https://docs.npmjs.com/cli/v9/configuring-npm/package-json#engines and causes the pipeline run to stuck because of an image tag error

image

This is how we fixed it on crossingguard (just removed the block to use the default node version): https://github.com/saritasa-nest/crossingguard-backend/commit/f9ad3266342a55a02fd2b067b2422493e6c618e2

Does it make sense to fix the task implemetation, or is it a viable solution to always pin a specific node version?

dmitry-mightydevops commented 1 year ago

@roman-mightydevops should be always pinned a specific fixed version.