search

sarkrui / NUC8i7BEH-Hackintosh-Build

[GUIDE] Installing macOS Mojave (10.14.x) on Intel NUC8i7BEH using Clover UEFI
345 stars 45 forks source link

Update M.2 NGFF Key B+M Adapter link #20

Closed UXnomaan closed 4 years ago

UXnomaan commented 4 years ago

The link to M.2 NGFF Key B+M Adapter is broken and I am unable to find one that would work. Can you please update the link?

Thank you

sarkrui commented 4 years ago

Hi, @ahgharian thanks for pointing out the issue. M.2 NGFF Key B M Adapter (AliExpress) Here 's the new link I found from AliExpress. Plus, A pull request doesn't work in that way. It should be 1) fork the repository; 2) modify the README and fix the broken link; 3) pull a request. Then I can decide whether to accept or reject. Thank you;

UXnomaan commented 4 years ago

That's what I did?

PR - from my fork to your master: https://github.com/sarkrui/NUC8i7BEH-Hackintosh-Build/pull/21

Commit - on my fork: https://github.com/ahgharian/NUC8i7BEH-Hackintosh-Build/commit/64e94d45dc2a535f3eb1646e9fb192000acc0057

Am I missing something?