search

sarmadhamdani02 / WebGames

This repo contains some web-based games, feel free to contribute 🙂 you can either create new games or contribute by solving issues.
https://webgames02.netlify.app/
9 stars 23 forks source link

Added bubble animation #44

Closed 09lkei closed 1 year ago

09lkei commented 1 year ago

Add bubble animation and changed color of bubbles to make the animation a bit more visible

sarmadhamdani02 commented 1 year ago

@09lkei Fantastic job 👏 I have requested some changes, have a look at them.

However, I had a thought about enhancing the bubble animations with a touch more randomness. Currently, they all animate together, but I believe it could be more visually appealing if we assign different animation times to certain bubbles.

Here's my idea: We could create multiple classes for the bubbles and randomly assign them to each bubble element. Then, in the CSS, we can apply the same animation but with varying animation times for each class. This could introduce a pleasing level of unpredictability to the bubble animations.

I'm not entirely sure if this will work 🤷‍♂️ since the bubbles are generated using JavaScript. What are your thoughts? 🤔

09lkei commented 1 year ago

I think I know how to make that work, I'll work on it shortly👍

sarmadhamdani02 commented 1 year ago

Sure 👍

sarmadhamdani02 commented 1 year ago

Wow, @09lkei, you've done an outstanding job! 👏