search

sarojvarma / include-what-you-use

Automatically exported from code.google.com/p/include-what-you-use
Other
0 stars 0 forks source link

hpp headers recommendation are not reported #46

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There is no include recommendation generated for *.hpp header files. Let me 
know where to look I will try to make a patch.

Original issue reported on code.google.com by wing1127aishi@gmail.com on 23 Jun 2011 at 3:57

GoogleCodeExporter commented 9 years ago 
I'd grep for ".h" in the source code.  It looks like GetCanonicalName() (in 
iwyu_path_util.h) is one place that needs to be adjusted.  There may be others, 
or that may be it.

Original comment by csilv...@gmail.com on 23 Jun 2011 at 5:20

GoogleCodeExporter commented 9 years ago 
This patch should resolve this issue. As we're matching .cc and .cxx we might 
as well look for .hh and .hxx too (both of which I've come across in the wild). 

Is it ok to apply?

Original comment by paul.hol...@gmail.com on 16 Jul 2011 at 9:20

Attachments:

GoogleCodeExporter commented 9 years ago 
Nice, thanks!  Look good to apply to me.

Original comment by csilv...@gmail.com on 18 Jul 2011 at 11:32

GoogleCodeExporter commented 9 years ago 
Great! Applied in r270.

Original comment by paul.hol...@gmail.com on 19 Jul 2011 at 8:16