search

saros-project / saros

Open Source IDE plugin for distributed collaborative software development
https://www.saros-project.org
GNU General Public License v2.0
159 stars 52 forks source link

Wizard to chose the local reference point mapping does not scale correctly in some cases #1043

Open tobous opened 4 years ago

tobous commented 4 years ago

The wizard to chose the local representation of shared reference points introduced in #1037 does not scale correctly, leading to fields not being visible at the end of the page. See screenshots below.

This is a bit annoying as the wizard also does not offer a scroll bar but rather has to be resized to access the field(s) at the end.

The issue seems to be caused by my local setup as I was not able to reproduce it on a Windows 10 machine running on default DPI (100% scaling at 1920x1080).

So it is probably one of the following three factors of my setup:

OS: Linux 5.6.13 (Arch) WM: i3-WM 4.18.1 (i3-gaps) Scaling: 144 DPI (2560x1440)

Cut Off Wizard ![wizard-cut-off](https://user-images.githubusercontent.com/12495415/85307407-2a96ef80-b4b0-11ea-98cf-c143e51630fc.png)
Full Wizard ![wizard-full](https://user-images.githubusercontent.com/12495415/85307386-24087800-b4b0-11ea-9932-44001289af76.png)
srossbach commented 4 years ago

Either the size is not correctly "calculated" or the Wizard has a fixed sized. There should not be a vertical scroll bar in this wizard. It does not make any sense.

I guess you did not experienced the usability of having a scrollbar widget inside a scrollbar widget. What I want to explain is: with the current screen resolutions (HD, UHD) there should be no need to introduce a scrollbar because even with a high DPI scaling there should be enough "room" so that the wizard will not "explode", i.e the wizard will not cover the whole screen surface.

tobous commented 4 years ago

There should not be a vertical scroll bar in this wizard. It does not make any sense.

Having a second scroll bar certainly was not my idea of a perfect solution or even a workable workaround. :sweat_smile:

I only mentioned the absence of a scroll bar as this makes it impossible to access the other fields without resizing the window.

Furthermore, it gives the user no way of knowing that there are other fields of the window that might not be visible. This is not that much of an issue in my case as it is somewhat apparent that there is a text box missing below the radio button. But, if this gets worse with higher DPI values, there is the possibility of the last radio button also not being shown, leading to a situation where the user could be left completely unaware of the option to use existing resources to represent the shared reference point, thereby severely reducing the usability/utility of Saros.

On a different note: This issue might also be related to the scaling issues I am experiencing with the Saros/I dialogs. For Saros/I, I manually adjusted the size of the wizard to fit my environment (which makes a dirty hack even dirtier as it only works for DPI values of 144 and below). But, as a result, it is way over-sized for default DPI scaling. (On the other hand, the Saros/I dialog looks kind of crap anyways, so it doesn't hurt that much. :sweat_smile:.)

So I will probably have to figure out if this is a configuration issue with my system or if there is something we can/have do about this on the software side.

srossbach commented 4 years ago

To be honest this issue is not new. Not new to Saros and many other programs. I remember my brother going nearly into rampage mode after he spent hours to assign macros to his mouse because the software was not showing the option due to increased DPI scaling.

Writing good size calculation algorithms is very time consuming and most of the time you do not gain anything. Things only start to get interesting if you change the DPI or translate your product to another language.

image