search

saros-project / saros

Open Source IDE plugin for distributed collaborative software development
https://www.saros-project.org
GNU General Public License v2.0
160 stars 52 forks source link

Workaround for compiling Saros/E with Java 8 #1115

Closed Drakulix closed 3 years ago

Drakulix commented 3 years ago

This is a temporary fix for #1114, which can be used to compile Saros/E with JDK version 8.

This is not a proposed solution and the workaround will need to be updated for every org.eclipse.platform, that we use and gets an update at this point. Actually discussion about long-term fixes should be done in #1114.

m273d15 commented 3 years ago

This change is sufficient for the build process, but I think you to add this workaround also to the stf build file(here). Otherwise, the stf testing pipeline will fail

Drakulix commented 3 years ago

This change is sufficient for the build process, but I think you to add this workaround also to the stf build file(here). Otherwise, the stf testing pipeline will fail

Thanks. Fixed

tobous commented 3 years ago

Since the proper resolution of #1114 will probably take a while, I don't see an issue with actually merging this PR to fix the master in the meantime. While we should not take it as a reason to delay resolving the underlying issue, having a buildable master makes working on the project easier, especially for newcomers interested in the project.

And even if the solution is implemented faster than expected, reverting the workaround is easy enough, especially since we already have the existing workaround for the previous issue that will have to be removed as well.