search

saros-project / saros

Open Source IDE plugin for distributed collaborative software development
https://www.saros-project.org
GNU General Public License v2.0
158 stars 52 forks source link

[Server] Invite Command does not add users to contact list #1121

Open jrtberlin opened 3 years ago

jrtberlin commented 3 years ago

Describe the bug

When Alice and Bob join Dave's Server, Alice and Bob can not chat, share projects or files with each other.

To Reproduce

Steps to reproduce the behavior:

  1. Compile the server with ./gradlew cleanAll sarosServer
  2. java -Dsaros.server.interactive=yes -Dsaros.server.jid=dave@examplexmppserver.de -Dsaros.server.password=passwd -jar saros.server.jar
  3. invite alice@examplexmppserver.de & invite bob@examplexmppserver.de
  4. Alice and Bob accept the invitation
  5. try to share a project in Eclipse, chat with a participant or send a file
  6. nothing happens and the server does not log any errors.

Expected behavior Alice and Bob can chat and collaborate on code.

Log files

Saros_2021-02-12_17-03-51.log

Environment (please complete the following information):

Drakulix commented 3 years ago

Cannot confirm. After a debugging session with @jrtberlin this look like this issue happens, if the server.jid and any client.jid have no added themselves to their contact list.

As the server accepts any subscription request automatically, adding the server via gui is not a problem. The reverse in the server-cli however is not true.

The invite command should likely first add any previously unknown contacts.

srossbach commented 3 years ago

Looking at the log file there seems to be configuration errors on the server side. The MUC channel is missing for some reason and so there will not be any session chat. The next strange issue is that there is no transport method defined.

FelixSelter commented 3 years ago

@Drakulix @jrtberlin Would you like to see this implemented as another command or do you want it to work with the default invite command?

I was trying to get started with contribution and thought this is an easy task. I could send a pull request just tell me which way you preferr

Drakulix commented 3 years ago

@Drakulix @jrtberlin Would you like to see this implemented as another command or do you want it to work with the default invite command?

I was trying to get started with contribution and thought this is an easy task. I could send a pull request just tell me which way you preferr

Hey thanks for reaching out. I would personally prefer this to be integrated into the existing invite command. In my opinion this is what the user expects, when they invite a new contact.