search

saros-project / saros

Open Source IDE plugin for distributed collaborative software development
https://www.saros-project.org
GNU General Public License v2.0
160 stars 52 forks source link

Closing edited files without saving problematic for readonly #21

Open dpp-gerrit opened 13 years ago

dpp-gerrit commented 13 years ago

When the host closes a file after changing it, without saving, all other hosts have a dialog triggered asking if the file changes should be saved.

Selecting "yes" as a readonly users results in an inconsistency (watchdog barks).

There should be no dialog for session participants - the reset of the file changes needs to be propagated to all participants in a consistent way without requiring user interaction.

Reported by: netcorps

Original Ticket: dpp/bugs/645

dpp-gerrit commented 12 years ago

This is a more generell problem. The Question is: "What do we do, if Alice closes a file that was also edited by Bob?" If you think a little bit ahead it gets even worse... Imagine a file "A.java" is opened by Alice, Bob an both can write to the file. What if Alice and Bob did made changes to "A.java" and Alice decides to close without saving? What do we do? If we want a convincing solution, we have to save all changes made by Bob and revert everything Alice made. This could be more complex if there are more than two programmers in the project. On the other hand we have to think about how likely this scenario is. So, is this really a level 7 bug?

Original comment by: donut87

dpp-gerrit commented 12 years ago

This happened in my heuristic evaluation, in my cognitive walkthrough and in the usability tests with participants in the company i work for.

So the frequency of occurences might be low, but the probability of it occuring is high. People type a comment to illustrate something while explaining in the code. Then close the file and not saving the temporary comment.

This should be fixed, but it is not a major problem, so i revied the priority.

Original comment by: netcorps

dpp-gerrit commented 12 years ago

> Selecting "yes" as a readonly users results in an inconsistency (watchdog barks).

Hmm, normally every user that is not the host must get an inconsitency warning.

This is really hard to fix, yes it is annoying. You explained a special case, in normal operation you are seldom writing code and then just discard it.

Can somebody test this scenario ?

Client X writes code ... after a while he noticed that his approuch was wrong and discard its changes.

Question: Are those changes also discarded on the host side ?

If not, you have to resync the file via watchdog, delete the newly written code and press save.

Original comment by: kargor