search

sarriaroman / FabricPlugin

Fabric.io plugin for Cordova or Phonegap
MIT License
198 stars 159 forks source link

Fixing plist kit: change to NSArray #111

Closed emcniece closed 6 years ago

emcniece commented 6 years ago

Updated plugin.xml so that iOS build no longer throws errors about the Info.plist kit value:

2017-11-03 11:58:34.908934-0700 Aurora[29568:9503199] Using Ionic WKWebView
2017-11-03 11:58:34.909494-0700 Aurora[29568:9503199] [CDVTimer][console] 0.069022ms
2017-11-03 11:58:34.909692-0700 Aurora[29568:9503199] [CDVTimer][handleopenurl] 0.091016ms
2017-11-03 11:58:34.911238-0700 Aurora[29568:9503199] [CDVTimer][intentandnavigationfilter] 1.447022ms
2017-11-03 11:58:34.911369-0700 Aurora[29568:9503199] [CDVTimer][gesturehandler] 0.039995ms
2017-11-03 11:58:34.948315-0700 Aurora[29568:9503199] [Fabric] [Fabric] Value of Info.plist[Fabric][Kits] should be a NSArray.
2017-11-03 11:58:34.948732-0700 Aurora[29568:9503199] [Crashlytics] Version 3.8.4 (121)
2017-11-03 11:58:34.958248-0700 Aurora[29568:9503199] [CDVTimer][fabricplugin] 46.806991ms

Resolves https://github.com/sarriaroman/FabricPlugin/issues/74 and https://github.com/sarriaroman/FabricPlugin/issues/50

Cyclic commented 6 years ago

Running into this - would be great to review and merge this on Monday, happy to test if it resolves the issue on my end. Please let me know if you want me to confirm that it resolves with steps to test installing the patch. Thank you!

emcniece commented 6 years ago

More testing is always welcome!

You could ionic cordova plugin install https://github.com/emcniece/FabricPlugin.git, or you can replace the contents of plugins/cordova-fabric-plugin/plugin.xml with the patched version, then ionic cordova build ios and run in XCode.