search

sarriaroman / FabricPlugin

Fabric.io plugin for Cordova or Phonegap
MIT License
198 stars 159 forks source link

Updated ios-helper.js in order to work with newer versions of XCode #154

Open andrerinaldi opened 5 years ago

andrerinaldi commented 5 years ago

I had this issue when installing the plugin:

Failed to install 'cordova-fabric-plugin': CordovaError: Using "requireCordovaModule" to load non-cordova module "xcode" is not supported. Instead, add this module to your dependencies and use regular "require" to load it. at Context.requireCordovaModule (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/Context.js:57:15) at Object.removeShellScriptBuildPhase (/Users/andrearinaldi/projects/beghelli/brain/plugins/cordova-fabric-plugin/hooks/lib/ios-helper.js:78:29) at module.exports (/Users/andrearinaldi/projects/beghelli/brain/plugins/cordova-fabric-plugin/hooks/after_plugin_add.js:21:19) at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32) at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16) at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20 at process._tickCallback (internal/process/next_tick.js:68:7)

and I solved it as you can see.

814k31 commented 5 years ago

@andrerinaldi there is also one at https://github.com/sarriaroman/FabricPlugin/blob/master/hooks/lib/utilities.js#L32 which you may want to add to the pull request? Did it manage to install okay without changing this one (I'm not apart of this package at all)

andrerinaldi commented 5 years ago

@814k31 the issue with requireCordovaModule was related to the "xcode" module only.. I managed to install the plugin without any further edit!