search

sarriaroman / FabricPlugin

Fabric.io plugin for Cordova or Phonegap
MIT License
198 stars 159 forks source link

Added support for Non Fatal Crashes on Android. #6

Closed nbdamian closed 8 years ago

nbdamian commented 8 years ago

I have added support for Non Fatal Crashed on Android. I am not sure how to go about adding support for IOS.

sarriaroman commented 8 years ago

Please check the Line Endings because is giving me a 100% difference in files.

nbdamian commented 8 years ago

This should have resolved it. Blame Notepadqq's hidden files.

sarriaroman commented 8 years ago

The Java part is not required because it will be taken by the Reflection method. Just the Javascript part was missing and the right documentation. Please remove the IF and I will proceed to merge it.

nbdamian commented 8 years ago

This has been removed.

sarriaroman commented 8 years ago

I don't want to bother you again but for some reason your last commit is taking the entire Java as changed again :(. With that change I will be able to merge it.

nbdamian commented 8 years ago

Darn Ubuntu xD It has been removed.

sarriaroman commented 8 years ago

Merged and released with v0.6.1

tomsun commented 8 years ago

Was curious, browsed through the history of this repo a bit...

Note that @nbdamian adds himself to authors in ec070bc94821a57aa52f9d40c7bf0888feb4724b but then removes himself again in the cleanup commit 2255836b33da938f11f224dd3662e307b0632ef1, probably unintentionally...

nbdamian commented 8 years ago

@tomsun With the little amount of code that I wrote, I didn't see it worth adding myself to authors.

sarriaroman commented 8 years ago

@nbdamian You can add yourself, you contributed to the improvement of the plugin! I'm glad of your help and for me it's ok if you add your name in the contributors list.