search

sarriaroman / FabricPlugin

Fabric.io plugin for Cordova or Phonegap
MIT License
197 stars 157 forks source link

Updated iOS SDK and changed bash script's relative path in workspace #63

Closed onderceylan closed 7 years ago

onderceylan commented 7 years ago

If you move generated iOS project workspace to another path, relative script path defined in project with the hook does not work anymore. Fixed that issue with scoping path within project workspace. Updated SDK as well.

sarriaroman commented 7 years ago

Hey @Justin-Credible can you review the PR just for Cross checking? Is ok for me.

Justin-Credible commented 7 years ago

The code change for the plugin path looks good to me.

As for the framework upgrade, it looks like Crashlytics takes a big jump from 3.6.x to 3.8.x. My only concern would be ensuring all existing functionality still works. Do we have a list of things that changed from 3.6 to 3.8 and how they affect the plugin?

Justin-Credible commented 7 years ago

I took at look at the Crashlytics SDK changelog and I don't see anything that worries me there. 👍

onderceylan commented 7 years ago

I also changed the script call from Crashlytics.framework/run to Fabric.framework/run as Fabric app guided me to do so.

onderceylan commented 7 years ago

I tested it with Crashlytics and it's working fine. I haven't tested Answers though.

sarriaroman commented 7 years ago

Merged and published to NPM

onderceylan commented 7 years ago

Great! Thanks 👍