search

sarriaroman / photoviewer

PhotoViewer Cordova Plugin
MIT License
157 stars 213 forks source link

iOS Crash on Version 1.1.17 #130

Closed LeoCreer closed 6 years ago

LeoCreer commented 6 years ago

iOS Crash on photoviewer Version 1.1.17

tested on ios 11.3 and 11.4 on iPhone X, 8 and 5s

Rolled it back to 1.1.16 and it everything started to work again.

erikramalho commented 6 years ago

Confirmed that 1.1.16 works fine.

writer0713 commented 6 years ago

@LeoCreer notice #129 . 1.1.17 author will fix it asap. for others who will see this issue, let me explain details.

1.1.16 : ios no problem. android share crashes. 1.1.17 : android share no problem(fixed). ios crashes with options (no options, no problem).

currently, @almas (who made 1.1.17) is checking it.

almas commented 6 years ago

I just fixed and created pull request. https://github.com/sarriaroman/photoviewer/pull/131 :) 👍

sarriaroman commented 6 years ago

Closed with 1.1.8. Thanks to @almas