sarriaroman / photoviewer

PhotoViewer Cordova Plugin
MIT License
157 stars 216 forks source link

base 64 png type #183

Open ganesh8184 opened 5 years ago

ganesh8184 commented 5 years ago

image is not opening with base 64 png type

syedarshad-dev commented 5 years ago

I am also facing the same issue with png image link. It works fine with jpg images.

ganesh8184 commented 5 years ago

Thanks Sarriaroman/Photoviewer, I have found the issue regarding this. Actually it is not about the png or jpeg. it all about the size of image if the image is base64.

the string data type can't hold that amount of base64, so need to use string builder or string buffer for url. Please use this logic if i am correct

On Mon, Sep 23, 2019 at 12:41 PM Syed Arshad notifications@github.com wrote:

I am also facing the same issue with png image link. It works fine with jpg images.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sarriaroman/photoviewer/issues/183?email_source=notifications&email_token=AFJLOCROQMRNPGDHYOLFFKDQLBTYXA5CNFSM4ITSRM7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7J7BFI#issuecomment-533983381, or mute the thread https://github.com/notifications/unsubscribe-auth/AFJLOCXPLPUMGGB2MJSAXTDQLBTYXANCNFSM4ITSRM7A .

-- Thanks & Regards Ganesh Hargude 9922591002

davidquon commented 4 years ago

@ganesh8184 Did you end up getting this working with string builder or string buffer for the URL? If so can you please share a snippet of what you got working? Thanks.

ImpacGroup commented 3 years ago

We've build an similar plugin from scratch that can handle base64 png. Take a look here: https://github.com/ImpacGroup/cordova-plugin-zoomimageview