sarsamurmu / estree-toolkit

Tools for working with ESTree AST
https://estree-toolkit.netlify.app/
MIT License
54 stars 1 forks source link

Property.key might not be a PrivateIdentifier #13

Closed HKGx closed 3 months ago

HKGx commented 1 year ago

https://astexplorer.net/#/gist/d3b754be4002e2073a4edf60cef78b90/999019efedfc3882485ab2be3340e217b9644b42

define({
  foo: null,
  bar: null,
})

Meriyah reports that both "foo" and "bar" are simple Identifiers and not PrivateIdentifiers.

sarsamurmu commented 1 year ago

Are these supposed to be PrivateIdentifiers? Can you elaborate?

HKGx commented 1 year ago

Are these supposed to be PrivateIdentifiers?

I don't really know. It's just how mariyah handles it. :shrug:

sarsamurmu commented 3 months ago

Closing it. If still have the problem then please reopen the issue.