search

sarthakarora02 / API_playground

A python project that downloads images from a particular twitter handle using Tweepy, converts them to a video using FFMPEG and describes the content of the video using Google's Video Intelligence API.
3 stars 0 forks source link

code review #1

Open xinshasha opened 6 years ago

xinshasha commented 6 years ago

Coding style is good and handles exceptions.(However, it's better to use print function in print("hello,world") but not print "hello,world". this can make it easier to run the code with other version of python.

the readme about building environment can be more clear. I installed all the libs described in ReadMe but still have a 'no module' problems.

I will update the review report after the environment problems have been solved and programs can be successfully run on my PC.

xinshasha commented 6 years ago

module are packed properly. and code is easy to read.

get_images.py

exception handler is ok to improve programs' robust. I forget to handle such items such as mkdir in my project. Thanks for your code.

analyse_images_video.py

handle with video properly,but can you upload a demo video to show your work?

sarthakarora02 commented 6 years ago

Enclosed are the links: 1) to the output I receive on the command line for the handle BU_Tweets when asked for 15 images. https://github.com/sarthakarora02/601_Mini_project_APIs/blob/master/src/demo_output.txt 2) to the downloaded images and the video formed through FFMPEG. https://github.com/sarthakarora02/601_Mini_project_APIs/tree/master/src/twitter_images