search

sarthakps / to-do

An Android app with added aesthetics and automation to help you organize and manage your daily routines and deadlines.
BSD 3-Clause "New" or "Revised" License
5 stars 9 forks source link

improvements required in swipe-to-delete list functionality #21

Open sarthakps opened 3 years ago

sarthakps commented 3 years ago

The current implementation of swipe-to-delete for the DeleteList feature in the swipe-to-delete branch needs certain improvements:

  1. The opening and closing speed of the delete view(the red rectangle), feels a little sluggish. Improve the opening and closing speed of the prompt such that it neither doesn't feel as sluggish as it is right now nor does it become way too fast. It should animate just perfectly.

  2. Fix the text size of the "Delete" text of the prompt. Currently it takes a hardcoded value as 30px. Implement functionality that takes a standard textSize value(in sp) from @dimen, converts it to px, and passes the same to the constructor.

  3. Once you have opened the prompt, to close it, you need to swipe through around 70% of the screen width. The prompt should close on just a flick. i.e. around 20-25%(or something lower or higher, whichever provides desired results) of the screen width. In summary, adjust the threshold.

  4. If you have the prompt already open on one list, if you swipe on another list, the prompt of the first list stays there and only recedes after the prompt of the second list is fully displayed. Fix this so that as soon as the user swipes on the second list, the prompt of the first list recedes. For a better animation, you could implement it such that both happen simultaneously.

  5. (Experimental) Instead of the "Delete" text in the prompt, place an icon(vector asset i.e. SVG only) of a trash bin. Use 24dp*24dp as the size of the icon. Use @dimen resource for specifying the size.

Guidelines for making PRs for these individual issues:

  1. The fix for each of the above issues is to added in an individual PR; i.e. open a single PR for a fix of a single issue from the above listed.

  2. The fix for each issue carries individual points to be awarded. And hence adhere to above guideline no. 1.

  3. These PRs for these fixes are to be made on the swipe-to-delete branch only.

  4. While making a comment under this issue, make sure to mention the number of the sub-issue from above(you may take atmost 3 at a time). And the allotted duration per sub-issue will be of 2 days.

rasacharjee commented 3 years ago

I want to work on sub-issue 5

rasacharjee commented 3 years ago

Can I work on sub-issue 2

sarthakps commented 3 years ago

I want to work on sub-issue 5

Fixed!

sarthakps commented 3 years ago

Can I work on sub-issue 2

Fixed!