Closed theaubmov closed 2 weeks ago
The recent updates primarily enhance the handling and propagation of message-related events in the application. Additional properties, such as correlation and element identifiers, have been introduced. The control flow, particularly in how messages are processed and correlated across different modules, has been refined. These modifications aim to enrich the message handling capabilities and improve the integration between various parts of the system.
Files | Change Summaries |
---|---|
app/app.js |
Updated spiff.add_message.requested event handler with new properties. |
app/spiffworkflow/messages/MessageHelpers.js |
Refactored loops for better efficiency and added msgObject parameter in methods. |
app/spiffworkflow/messages/propertiesPanel/elementLevelProvider/MessageLaunchEditorButton.js |
Added elementId to the event object and fired a new event before sendEvent . |
app/spiffworkflow/messages/propertiesPanel/elementLevelProvider/MessageSelect.jsx |
Modified element references and updated message handling logic. |
app/spiffworkflow/messages/propertiesPanel/elementLevelProvider/TaskEventMessageProvider.js |
Added elementRegistry parameter to createMessageGroup function. |
test/spec/MessagesSpec.js |
Simplified correlation_properties by using single strings instead of arrays. |
sequenceDiagram
participant User
participant UIComponent
participant EventBus
participant MessageHelpers
participant Registry
User->>UIComponent: Interact (e.g., button click)
UIComponent->>EventBus: fire('spiff.add_message.requested', { name, correlation_properties, element })
EventBus->>MessageHelpers: handleEvent(event)
MessageHelpers->>Registry: updateCorrelationProperties(element)
Registry-->>MessageHelpers: Properties updated
MessageHelpers-->>UIComponent: Correlation updated
UIComponent-->>User: Display update
Amidst the code, the rabbits hopped, Enhancing messages, they never stopped. With properties strong and elements bright, They crafted a system that felt just right. Now events flow with seamless grace, Bringing smiles to every userโs face. ๐๐ป๐
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Supports https://github.com/sartography/spiff-arena/pull/1714
Summary by CodeRabbit
New Features
spiff.add_message.requested
event handler with additional properties:name
,correlation_properties
, andelement
.spiff.add_message.requested
with{ eventBus }
toMessageLaunchEditorButton
.ELEMENT_ID
inMessageSelect
.Refactor
Bug Fixes
MessageSelect
.correlation_properties
structure in tests for consistency.