search

sartography / bpmn-js-spiffworkflow

A BPMN.js extension to improve working with SpiffWorkflow - the python BPMN engine.
MIT License
22 stars 4 forks source link

strip out quotes when user types them for error boundary error code #90

Open burnettk opened 4 months ago

burnettk commented 4 months ago

Alex: Another issue is that if the user enters the Error Code with quotes, which is our standard convention, it does not work. But does without quotes, which our standard convention says should be interpreted as a variable.

KB: yeah, that's confusing. i assume in this case there is no option to evaluate it.

Elizabeth Esswein: this field is always a string. So in fact, quotes would be misleading. People already get bitten when they put in a number and expect to be able to compare it to an int. Having quotes introduces the expectation that there could be other types besides strings.

KB: i wonder if we could just strip them out if you type them. first i thought helpful error message, but then i was like, that's annoying

Elizabeth Esswein: Stripping would be a viable option i think

madhurrya commented 4 months ago

I think we'll have to do the same in Escalation codes also.