search

sartography / bpmn-js-spiffworkflow

A BPMN.js extension to improve working with SpiffWorkflow - the python BPMN engine.
MIT License
19 stars 5 forks source link

ID field with spaces and other special characters #91

Open madhurrya opened 1 month ago

madhurrya commented 1 month ago

In the editor for ID field of items like Errors, Signals, Escalations, Dataobjects etc. if we enter a space or some special characters like &, # etc after we save that model and load it then that item is missing. For example please see this video. https://drive.google.com/file/d/1heEO21hpSWP_yWLfNG2yEOb9LNWWXMqc/view?usp=sharing

image

image

jasquat commented 1 month ago

It actually gets added to the xml but then it isn't displayed when reloading the diagram. After saving the diagram again, the error is removed from the xml. In general spaces are not allowed in id's I think so maybe we should not allow special characters or spaces in it if we can.

madhurrya commented 3 days ago

  1. The Ids get trimmed for the boundary events if there is a space. But if there are special characters in the Id, the above issue is still there.

  2. For the process Id if I type with a space it shows a warning, but I can save it. Then when I open it again, the diagram is missing. Please see this video. https://drive.google.com/file/d/11pYgPdswafGsRHXX1QvYT8RCTk3bMq-i/view?usp=sharing