search

sartography / bpmn-js-spiffworkflow

A BPMN.js extension to improve working with SpiffWorkflow - the python BPMN engine.
MIT License
22 stars 4 forks source link

Button Label Resets on Signal Boundary Event #93

Closed dinithihj closed 3 months ago

dinithihj commented 6 months ago

I have created a process model with a signal boundary event and added some text to a button label. If I click on some other element and then go back to the signal boundary event, the text on the button label disappears and resets.

Process Model - https://dev.app.spiff.status.im/process-models/misc:qa:test-signal-event Video Link - https://drive.google.com/file/d/1chwtR5I_rDATCWycaHx8XuE1q_siNFo5/view?usp=sharing

After saving the model, the button label is stored in the XML file. I can see the button text when I run the process model. The issue is that the button text doesn't appear in the property panel on editor.

madhurrya commented 4 months ago

I think this is a common issue for other boundary events like Error, Escalations etc

theaubmov commented 4 months ago

@madhurrya @dinithihj , The issue has been resolved, and I've raised a PR for it.

To provide some context on why it wasn't working for events like errors and escalations: This occurred only when the error select had no value. To prevent users from encountering this issue, the code and variable name input will now be displayed only if there is a value in the error select input, escalation, or signal. This way, users will only see the code and variable name when necessary.