hide_expression not evaluating correctly

sartography / cr-connect

0 stars 0 forks source link

hide_expression not evaluating correctly #440

Closed calexh-sar closed 2 years ago

calexh-sar commented 3 years ago

I added the Hide Test workflow to the Test Example Workflow Specification and functions the same way: and

whether the Test2 Property is set to: or

cullerton commented 3 years ago

@calexh-sar This might be because of the parenthesis. I removed them and it seems to be working. If hide_expression is Test1, the field is hidden on Yes, and displayed on No if hide_expression is not Test1, the field is displayed on Yes, and hidden on No

calexh-sar commented 3 years ago

Here is what I am seeing: if hide_expression is not Test1, the field is displayed on Yes, and hidden on No If hide_expression is changed to Test1 and I click Start over, I still see the field is displayed on Yes, and hidden on No. But if I then do a browser refresh, the field is hidden on Yes, and displayed on No. And why are the parenthesis no longer working? I have always used not(boolean) and seldom if ever not boolean in all other expressions of this type?

cullerton commented 3 years ago

@danfunk I'm giving you the expression tickets

danfunk commented 3 years ago

I've tested this carefully, and I no longer see this issue.

Parens are valid, but not required for the NOT operator. Both work.
Because this is the first form on the page you aren't getting a refresh of these evaluation functions and they have already been run on these fields, that's why the browser refresh produces the expected behavior, and a restart does not. We could force a reload of the page on a restart.

calexh-sar commented 2 years ago

Working as designed.