sartography / cr-connect

0 stars 0 forks source link

API has two different endpoints that do the same thing, but use different authentication methods #490

Closed w4kpm closed 2 years ago

w4kpm commented 3 years ago

/workflow-specification/{spec_id}: /workflow_sync/{workflow_spec_id}/spec:

Acutally do exactly the same thing api.workflow.get_workflow_specification BUT I couldn't get multiple authentication methods to work correctly

Essentially,

/workflow-specification/{spec_id}: should respond to both

the second endpoint should be removed, the stub should be removed from api/workflow_sync.py (get_sync_workflow_specification) the method get_remote_workflow_spec should be updated to use the new API endpoint. in services/workflow_sync.py

w4kpm commented 3 years ago

For what it's worth, this seemed to fail when I tried it on this endpoint, but did work when I tried it on the github endpoints. - will update this if it works.

danfunk commented 2 years ago

Instances no longer talk directly to each other, but through GIT as an intermediary. So we no longer have multiple authentication methods.