sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
63 stars 42 forks source link

Feature to auto-commit Data Store Changes to process_group.json #1084

Open dinithihj opened 6 months ago

dinithihj commented 6 months ago

Related to PRs https://github.com/sartography/spiff-arena/pull/1040 and https://github.com/sartography/spiff-arena/pull/1056

The process_group.json file only gets updated when we create/update process groups/models, not when we create or update data stores. There should be a feature to auto-commit Data Store changes to the process_group.json

For example, I created a data store named "Watches" at https://dev.app.spiff.status.im/process-groups/misc:qa:data-store-tests and then looked at the relevant process_group.json file, I didn't see any entry for data store "Watches". After about an hour, I updated a process model, at this point the process_group.json file was updated and written an entry for the data store "Watches".

When I checked the details of the commit, both the change to the data store and the change to the model were committed together, even though I made the data store change about an hour earlier.

It's the same when creating a data store at the root level. I made a data store called "Laptops" at the root level, at the same time I created the above data store "Watches". The process_group.json file at the root level got updated along with the model change I mentioned earlier.

Here's the commit. https://github.com/status-im/process-models/commit/0af07a017c4f1a8a86812e964c760a63f42c088f

madhurrya commented 4 weeks ago

@calexh-sar are we going to keep this issue?