search

sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
53 stars 38 forks source link

Editor - Save disabled and can't save #1093

Open madhurrya opened 5 months ago

madhurrya commented 5 months ago

I was testing the issue related to not being able to delete a message start event. When I got this error, I went to the other model mentioned in the error and and updated it.

Image

  1. Now I want to save this model again without any update. But I can't do that since the save button is disabled. Do we need to consider that kind of scenarios?
  2. Then I typed something in the 'Variable name' text box to get the Save button enabled. But that didn't enable the save button. I had to go to a different text box and edit it.
madhurrya commented 5 months ago

Another question related to Save message. If I open the Script editor and just close it, it show the 'Unsaved changes' warning message. Can we show it only if the script really changed? Is it difficult?

Image

calexh-sar commented 5 months ago

I had a similar issue that the Save button stayed disabled after updating the Called Element Process ID of a Call Activity.

Image

burnettk commented 5 months ago

i'm guessing in that case that if you had clicked the save button before (after updating the called element id), it would not have actually saved the change. but not certain.

jasquat commented 5 months ago

The xml does actually change when updating the that process id so saving should have updated the file. I tested this using the "Download" button and the xml did actually change. I'm not sure how that doesn't trigger an event. It seems like some of our custom fields do not send the event properly.

The issue where clicking "Launch Editor" and such for a script task was always an issue. It's just more visible now.

For the main issue, we could keep the state as "true" if the save fails for some reason so the Save button remains active.

madhurrya commented 3 months ago

Seeing the same issue that Alex mentioned for Call activities when setting the Process ID.

madhurrya commented 3 months ago

Some times noticing weird behavior with the save button. It doesn't get enabled sometimes like in the latter part of this video. Noticed a similar thing with another model today earlier. But now when I try with the same model it works. Not sure whether it happens due to other issues in the model/editor. https://drive.google.com/file/d/1hdBH__GxB1PnACl_mRcFt40x6pMJgOqL/view?usp=sharing

madhurrya commented 1 month ago

For events with conditions also, when we add/edit a condition the Save button doesn't get enabled.

542