search

sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
49 stars 36 forks source link

Unit tests passed even when some multi instance models are failed #1380

Open dinithihj opened 2 months ago

dinithihj commented 2 months ago

Below multi-instance models are failing on the Time Tracking site However their unit tests are passing successfully. Unit Test shouldn't pass when the model itself is failing.

  1. https://timetracking.spiffworkflow.org/process-models/bpmn-unit-tests:expected-to-pass:single-activity-tests:mi-parallel-user-task-loop-cardinality https://timetracking.spiffworkflow.org/i/4094

  2. https://timetracking.spiffworkflow.org/process-models/bpmn-unit-tests:expected-to-pass:single-activity-tests:mi-parallel-user-task-input-collection
    https://timetracking.spiffworkflow.org/i/4095

  3. https://timetracking.spiffworkflow.org/process-models/bpmn-unit-tests:expected-to-pass:single-activity-tests:mi-sequential-user-task-loop-cardinality https://timetracking.spiffworkflow.org/i/4096

  4. https://timetracking.spiffworkflow.org/process-models/bpmn-unit-tests:expected-to-pass:single-activity-tests:mi-sequential-user-task-input-collection https://timetracking.spiffworkflow.org/i/4097

  5. https://timetracking.spiffworkflow.org/process-models/bpmn-unit-tests:expected-to-pass:single-activity-tests:call-activity-with-mi-sequential-user-task-input-collection https://timetracking.spiffworkflow.org/i/4100

  6. https://timetracking.spiffworkflow.org/process-models/bpmn-unit-tests:expected-to-pass:single-activity-tests:sub-process-with-mi-parallel-user-task-loop-cardinality https://timetracking.spiffworkflow.org/i/4101

  7. https://timetracking.spiffworkflow.org/process-models/bpmn-unit-tests:expected-to-pass:single-activity-tests:expanded-sub-process-with-mi-sequential-user-task-loop-cardinality https://timetracking.spiffworkflow.org/i/4102

jasquat commented 2 months ago

We're forcing these to complete - https://github.com/sartography/spiff-arena/blob/main/spiffworkflow-backend/src/spiffworkflow_backend/services/process_model_test_runner_service.py#L266-L272

Maybe this should follow ProcessInstanceService.complete_task more closely where we update the task data but still run the task. That may fix this.