sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
73 stars 44 forks source link

Data Object with sensitive fields, should only mask the field values not the field itself #1437

Closed harmeet-status closed 5 months ago

harmeet-status commented 6 months ago

Data Object with sensitive fields, should only mask the field values not the field itself.

See @MarD0607 comment below for details https://github.com/sartography/spiff-arena/issues/1437#issuecomment-2074575808

calexh-sar commented 6 months ago

@harmeet-status Spiff is not fined grained enough in our permission system at this time. Need additional information about the use cases you have in mind.

MarD0607 commented 6 months ago

@calexh-sar The use case and how I see it happening in Spiff is the following:

The only part which I need to figure out is when we need as part of the process to pass the data fields and the values to a service task, like a POST url, because we would need do decrypt the values before passing them on as output data. However we should not be able to see the values even then.

I can try building this myself with support from you.

danfunk commented 6 months ago

2 Options:

1) Add Json Schemas to data stores, add some non-standard flag to fields in a data store that signify that information should be redacted - would require some additional front-end, backend-end and bpmn-io work to fully implement.
2) We split the data objects up so that only the data that needs to be secured is stored there.

Discussed all options, and Marius will try option 2 and get back to us.

calexh-sar commented 5 months ago

@MarD0607 any feedback on this?

MarD0607 commented 5 months ago

Option no.2 is a valid approach It requires additional scripting in order to separate unsensitive data from sensitive data before creating the data object

calexh-sar commented 5 months ago

@harmeet-status is option #2 sufficient going forward? If so, will close this issue. If not, we will estimate option #1.

harmeet-status commented 5 months ago

Ok close ticket. Going with option 2.

calexh-sar commented 5 months ago

Closing per Harmeet's comment