Closed jasquat closed 3 weeks ago
The updates primarily enhance the SpiffWorkflow backend's functionality and robustness. Key changes include the introduction of a process_instance_id
parameter in execution and import scripts, improvements in data handling through the KKVDataStore
, and method enhancements in service classes to support better task and process instance management. Additionally, there's a focus on refining data migration scripts and expanding unit tests to cover new functionalities.
File Path | Change Summary |
---|---|
.../execute_tasks_for_process_instance.py & .../import_process_instance_from_bpmn_json.py |
Added process_instance_id parameter handling in main functions. |
.../old_proc.json |
Added a BPMN workflow definition for a message send process. |
.../data_migrations/version_4.py |
Removed unused return None statement in run method. |
.../data_stores/kkv.py & .../services/workflow_execution_service.py |
Major updates to KKVDataStore , including method restructuring and integration into workflow execution. |
.../services/process_instance_service.py |
Enhanced run_process_instance_with_processor and updated complete_form_task to include data dumping. |
.../tests/data/data_store_simple/data-store-simple.bpmn |
Defined a simple BPMN process with various workflow elements. |
.../tests/.../test_kkv_data_store.py |
Expanded unit tests with new methods and additional module imports. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Addresses https://github.com/sartography/spiff-arena/issues/1359#issuecomment-2077274788
This adds a method to KKVDataStore that adds the getter back onto tasks when they run. This is due to the script engine removing methods from the task data when it serializes. These getters are added to the tasks when the task is marked READY and therefore may not be there when we actually run the task.