sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
44 stars 34 forks source link

Saving BPMN file takes long time (dev.app) #1461

Open sashayar13 opened 2 weeks ago

sashayar13 commented 2 weeks ago

I timed saving the file in the dev.app several times, and it took an average of 16 seconds.

jasquat commented 2 weeks ago

My save time seems to be down to ~2 seconds on dev.app now. It probably could be better but at least it's not 16 anymore.

madhurrya commented 1 week ago

It is still taking time. https://drive.google.com/file/d/1l2Qkf0haFI6dRogOWB7Yjqx-4GS462eK/view?usp=sharing

Tried couple of models, It seems when I save it first time after opening it, it takes time like this. But when I save it the next time it seems faster.

https://drive.google.com/file/d/1tebsU4t0dDf5CFqH40hPYeKDun7QkhW_/view?usp=sharing

jasquat commented 1 week ago

@madhurrya What environment were you on? On dev.app it's saving quickly for me in that model: https://dev.app.spiff.status.im/editor/process-models/misc:test:madhurya-testing:boundary-event-test/files/httpv2.bpmn

madhurrya commented 1 week ago

It was in dev.app. As I mentioned it seems to happen for the first time. I am not sure exactly. As you can see in the second video, for me also it saved quickly the second time.

jasquat commented 1 week ago

Yeah that is odd. It's consistently faster for me.

@madhurrya keep you network tab open while you do it. See if there's anything going on in there.

madhurrya commented 1 week ago

For me its the behaviour for any random model I try. First time it takes about 20 -30 secs and next time it saves in few seconds. https://drive.google.com/file/d/1KxDWaat_wT1YdI9mAO69zbvASWXk6ywW/view?usp=sharing

This video has the network tab opened. Didn't notice any issue there. But in the first one, the response says no data to show, but when I go to the preview, it shows data. https://drive.google.com/file/d/13YFcZuFiiYRKcRa6IsGBy8ubjLlQHK2t/view?usp=sharing

you can see the same here also with the network tab. https://drive.google.com/file/d/1Oj6-WWmNpzl6Hdvtf8HxUy6pLo8pSLVA/view?usp=sharing

madhurrya commented 1 week ago

Above are from Edge and checked from Firefox to see whether it's browser related and still noticing the same. https://drive.google.com/file/d/1XJhtjnzixlKwQq0JaZOyKE2Eer3C4c5f/view?usp=sharing

madhurrya commented 1 week ago

Created a new model and saved it and it works fast.

madhurrya commented 1 week ago

@burnettk @jasquat I am still seeing the same behaviour for all the existing models. When I open and save it for the first time (not exactly sure what this first time is, I am opening these models after some time) it takes about 30 secs to save. But after that it saves fasts. Can you please try opening and saving a model that you have not opened/saved in some time and see.

@sashayar13 does everything looks OK to you?

jasquat commented 1 week ago

@madhurrya yep I've done that and haven't seen the issue. It's 1 to 3 seconds to save. Tried it with browsers I don't use much to make sure it's not a cache thing but I'm not sure how that could factor into it.

madhurrya commented 1 week ago

Dinithi also didn't notice my issue. If everything looks OK to @sashayar13 I'll close this ticket.

sashayar13 commented 1 week ago

looks a lot better - saving the changes much after - thank you!

madhurrya commented 1 week ago

Since I am the only one who is noticing the above behavior I'll close this ticket for now.