sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
73 stars 44 forks source link

MI parallel completion condition #1512

Open burnettk opened 6 months ago

burnettk commented 6 months ago

And this one doesn't seem to work as expected. It should ouput only up to 4 because of the completion condition. But it doesn't work like that.

https://dev.mod.spiff.status.im/process-models/misc:qa:bpmn-model-testing:unit-test-multi-instance-parallel-loop-cardinality https://dev.mod.spiff.status.im/i/36220 This is how the output looks in dev.app for the same model - https://dev.app.spiff.status.im/i/3599

see discussion between jasquant and elizabeth on #1362

jasquat commented 6 months ago

The theory here is that with celery the mi child tasks are created and then saved to the db and the pi is queued to run again. This causes the pi to be loaded from the db which loads the task based on guid order which is probably not the order spiff originally had them in. This means we run them out of order and spiff tries to test the condition in a different order which causes this issue.

madhurrya commented 6 months ago

Is this also fixed now? It worked today.

Image

jasquat commented 6 months ago

It seems doubtful it's fixed. We think it's random. It may work sometimes and it may not others.

madhurrya commented 4 months ago

Yeah, it's not fixed yet. image