sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
56 stars 40 forks source link

Multi Instance User tasks - after rjsf update #1664

Open madhurrya opened 2 months ago

madhurrya commented 2 months ago

Noticed that with the latest updates, now when we run a Multi instance user task (both parallel and sequential), the next user form shows the previous form's values. Earlier it didn't happen like that. I don't know whether this is something that needs to be fixed or not.

Please check these 2 videos. https://drive.google.com/file/d/1OvU08twwuMlYfPEwAk5Ohzlqj20brzNO/view?usp=sharing https://drive.google.com/file/d/1EVHDo22FgHWYCLf2NfBKbUIRHaSjQlnf/view?usp=sharing

Or you can check with these models https://dev.app.spiff.status.im/process-models/misc:qa:bpmn-model-testing:unit-test-multi-instance-sequential-user-task-loop-cardinality https://test.app.spiff.status.im/process-models/misc:qa:bpmn-model-testing:unit-test-multi-instance-sequential-user-task-loop-cardinality

https://dev.app.spiff.status.im/process-models/misc:qa:bpmn-model-testing:unit-test-multi-instance-parallel-user-task-input-collection https://test.app.spiff.status.im/process-models/misc:qa:bpmn-model-testing:unit-test-multi-instance-parallel-user-task-input-collection

madhurrya commented 2 months ago

Also noticed that in test.app we can submit the above forms without entering any data in the text field. But in dev.app when we do that it gives an error.

burnettk commented 2 months ago

for the second issue, where we used to be able to submit the form without entering any data, i think this is the same issue as that we experienced elsewhere where we no longer get task data keys when the value is blank. this is a change in react json schema form, and will require process model changes (which i think have largely already been completed for the important process models). so i think we can ignore that symptom in the context of this ticket.

madhurrya commented 1 month ago

Above issue seems to be fixed now