Spiff bounties Submission - process Issues

[madhurrya]

~1. It seems 2 new fields have been added to the form I think it's better to show the Additional notes field at the bottom and Priority before that. What does this Priority actually means?~

[harmeet-status]

1. It seems 2 new fields have been added to the form I think it's better to show the Additional notes field at the bottom and Priority before that. What does this Priority actually means?

Yeah that's just me playing around @madhurrya. Reverted it back.

[madhurrya]

2. If we have removed the one time password then we need to update these messages also

[madhurrya]

3. Spelling mistakes

[madhurrya]

4. When I submit my details then it just says 'Thank You'. It's better explain there what happens next.

[madhurrya]

5. Suggestion - Since the user can request for more than one bounty, it might be better to show the Issue number also here.

and for this one also

[madhurrya]

6. I have set the label as Bounty compete. But it says it's not a Bounty issue. https://github.com/sartography/bpmn-js-spiffworkflow/issues/103

[madhurrya]

7. If the user accidently closes the the bounty form, when he tries to open the link again it gives this error.

Shouldn't the user be able to open it again? If we are blocking it on purpose I think we should show a proper message (UI/UX). If we are not blocking it then the user should be able to open the completed form and complete it.

[madhurrya]

8. We need to show 2 decimal places (Harmeet asked to add this)

[madhurrya]

9. Is this value three hardcoded? Currently this issue is not assigned to anyone but it says it assigned to three.

[madhurrya]

10. It seems the font type/size in these 3 are different. Better to use the same font and format

[madhurrya]

11. For this also it is saying 'Issue is not a bounty issue.' https://github.com/sartography/SpiffWorkflow/issues/420

[calexh-sar]

@madhurrya pls retest 6. and 11. Labels are case sensitive and I updated the labels in the bpmn-js-spiffworkflow and SpiffWorkflow repositories to all lowercase.

Regarding 7., I defer to @burnettk or @jasquat as to whether the guest link can be used again.

Please retest 8.

Please retest 9.

Regarding 10., the Process Architect does not have any control over the fonts used in the Instructions or the form. This should be moved to a separate issue that can be resolved when we work on the UI for these sections.

Regarding 4., I rearranged the flow so the bounty hunter's part always ends on the same Guest User Task, Complete Bounty Request, and indicated where @harmeet-status can add any closing instructions he would like while he is addressing the other text issues you found.

[harmeet-status]

2. fixed: Discord message updated.

[harmeet-status]

Improvements

12. @calexh-sar can you pls add a URL to the XML, in the below screenshot.

13. Add bounty name and URL here

14. Remove the OTP rule from the dmn table, we no longer use this

15. I want to add a new line here but I can't get it working. I tried adding 2 whitespace lines, and even 3 however it didn't work. It keeps looking like this

[harmeet-status]

16. Update the process flow to this

[harmeet-status]

17. We don't need this screen anymore, since we no longer use OTP. Jump straight to the next form.

[harmeet-status]

18. I can't see where the text above the title comes from, it's not in the JSON

[harmeet-status]

19. When clicking a URL which has expired, we need to show a nicer error message: Oops! Looks like this URL has expired. Please start from the beginning and resubmit the form.

[harmeet-status]

20. Update this page as follows:

Title: Bounty application complete Body: Thank you for applying to work on this bounty. We will review your application and get back to you ASAP. We may get in touch with you over Discord to discuss any further details that we need.

[harmeet-status]

~~21. Upon form load, dont auto pick a radio button, this could lead to accidental error ~~

[harmeet-status]

22. What is this suppose to show?

[harmeet-status]

23. Add line breaks here and some spacing

[harmeet-status]

24. This page needs the following content:

Title: Bounty already assigned Body: You are already assigned to this bounty. If you meant to apply for another bounty, please start a new form.

Button: Start new form

[harmeet-status]

25. We don't need this page anymore. Look at 24. and we can just send them back to the main form - start from scratch

[harmeet-status]

26. Entering the wrong bounty number, doesn't do a validation check, it just let's it though as if it's correct

[harmeet-status]

27. Eth address validation should be done against etherscan API which checks account balance. https://sebs.github.io/etherscan-api/#balance

[calexh-sar]

@harmeet-status -

12, #13, #15, #20 and #23 are ready for your review. The url for #12 needs to be updated with the desired link.

Regarding #14, which DMN table are you referring to?

[calexh-sar]

@harmeet-status regarding #17, I had to add that Manual Task when the OTP was removed since Guest Link sent needs a single Human Task destination and the flow beyond it can either go to the "Show Not Bounty Issue" Manual Task or the "Show Bounty - Compete Confirmation" User Task or the "Complete Bounty Request" User Task next.

[calexh-sar]

@harmeet-status regarding #18, the text can be found in the Instructions of that User Task.

[calexh-sar]

@harmeet-status - Regarding #21, this is an older format and no longer valid. Regarding #22, this shows additional bounties to which the requestor has been assigned.

[calexh-sar]

16. Update the process flow to this

Created #1860 for this update.

[calexh-sar]

@harmeet-status regarding #24, we should discuss further once #1727 is completed.

[calexh-sar]

@harmeet-status regarding #25, we cannot take them back to the "main form: since that is only accessible during the initial unauth Message Start Event flow. By this time the bounty hunter is in the Guest Link flow.

[calexh-sar]

@harmeet-status regarding #27, this exchange can be found in #979:

Are you saying now you want to reverse that decision?

[calexh-sar]

@harmeet-status regarding #26, I am seeing that a wrong number is getting a validation, both if a valid issue number that does not have a bounty label or if an invalid issue number are entered.

Do you have a specific number you tried that the process "just let's it though as if it's correct"?

[harmeet-status]

@harmeet-status regarding #17, I had to add that Manual Task when the OTP was removed since Guest Link sent needs a single Human Task destination and the flow beyond it can either go to the "Show Not Bounty Issue" Manual Task or the "Show Bounty - Compete Confirmation" User Task or the "Complete Bounty Request" User Task next.

If you need that step, let's put the OTP back in.

[harmeet-status]

@harmeet-status regarding #27, this exchange can be found in #979:

Are you saying now you want to reverse that decision?

Yes reverse decision. Let's check for valid address.

[harmeet-status]

@harmeet-status regarding #25, we cannot take them back to the "main form: since that is only accessible during the initial unauth Message Start Event flow. By this time the bounty hunter is in the Guest Link flow.

Ok then, leave as-is. Text change as follows:

Title: Spiff Bounties - Application Form Body: Please specify the bounty information below and check the data before submitting.

[harmeet-status]

@harmeet-status - Regarding #21, this is an older format and no longer valid. Regarding #22, this shows additional bounties to which the requestor has been assigned.

For 22. please change heading to: Bounties currently assigned to you

[calexh-sar]

@burnettk and/or @jasquat would you please look at #7 and #19 above and let me know if there is anything from a process POV that can be done to address either/both of these concerns. And if not, should this be written up as one or two issues so they can be addressed elsewhere.

[calexh-sar]

@harmeet-status added #1867 to account for time to add the OTP back.

Changed my mind, not needed anymore. We will instead just change the wording on the existing page.

[harmeet-status]

7. If the user accidently closes the the bounty form, when he tries to open the link again it gives this error.

Shouldn't the user be able to open it again? If we are blocking it on purpose I think we should show a proper message (UI/UX). If we are not blocking it then the user should be able to open the completed form and complete it.

The link should only work 1 time. Otherwise we could have edge case where a user has multiple discord message links which all work - cause the form wasn't submitted for any of them. This is a worse outcome, so let's leave the expiration of link 1 time use, like it is right now - no change.

The error message should be updated to this: https://github.com/sartography/spiff-arena/issues/1752#issuecomment-2201996431

[harmeet-status]

Change to following:

Title: Discord account verified Body: Thank you for verifying the Discord account belongs to you.

Button: Next

[harmeet-status]

Change this to:

Title: We hope to see you soon Body: Feel free to browse and apply for other Spiff Bounties [add link to Github board here].