search

sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
57 stars 40 forks source link

Messages - Correlation property names need proper validation #1814

Open madhurrya opened 2 months ago

madhurrya commented 2 months ago
  1. When I have used spaces in the Correlation property name, it caused issue number 2 and 3 (may be 4 also) in this https://github.com/sartography/spiff-arena/issues/1764 And when I used a apostrophe it caused issue number 9 there.

For the message name we have said that no spaces and special characters are allowed. But for the correlation property name no such message is shown, so I assumed I can use spaces there.

Image

  1. And we are not validating the user inputs for the message name/correlation property name/retrieval expression. I think we should validate it and if there is an issue which what the user has entered we shouldn't allow to save it.
madhurrya commented 1 month ago

@theaubmov please correct the spelling in the word message here image

And in the 2 places where or is used I think it should be 'nor' instead. But I am not 100% sure about :-)