sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
66 stars 43 forks source link

Messages - Message payload in Pre script #1842

Closed madhurrya closed 1 month ago

madhurrya commented 3 months ago

Adding this issue https://github.com/sartography/spiff-arena/issues/1626#issuecomment-2160046500 as a separate issue so I can close the above ticket.

If I define the payload in the Prescript of the Send task, it doesn't recognize it. But if I define it in a script task before that then it works. Is that the expected behaviour?

Image

Image

jasquat commented 3 months ago

I'm guessing the pre-script doesn't execute until the task is completed however the message payload needs to be available before the task can complete. I'm not sure what we can do about that.

@essweine does that sound right to you?

essweine commented 3 months ago

Fixed in library in https://github.com/sartography/SpiffWorkflow/commit/7e15a0b68f926161bfa88e1306f3145ee028fad4

The prescript and postscript were not being parsed on events.

calexh-sar commented 1 month ago

Closed per sprint planning discussion.

madhurrya commented 1 month ago

Yes, this is fixed now. Test model : https://mysql.spiffcrm.com/editor/process-models/misc:qa:bpmn-model-testing:unit-test-send-task-new/files/unit-test-send-task-new.bpmn