sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
66 stars 43 forks source link

Order of the instructions displayed dev.app vs dev.mod #1866

Open madhurrya opened 3 months ago

madhurrya commented 3 months ago

Please run this same model on dev.app and dev.mod. The order of the instructions are displayed seems different. For example the Call activity instructions are displayed at the start in dev.app and at the end in dev.mod. Is it something expected in Celery?

https://dev.mod.spiff.status.im/process-models/misc:test:madhurya-testing:interstitial-instructions-test https://dev.app.spiff.status.im/editor/process-models/misc:test:madhurya-testing:interstitial-instructions-test

Please watch this video - https://drive.google.com/file/d/16FN1TnAF82ErQ2rJyz0wXPXIqL99NuG_/view?usp=sharing

jasquat commented 3 months ago

Oh so the instructions are on the call activity. So we grab instructions from a task when it's in state READY. Call activities and subprocesses I believe, are in state WAITING until their contents are complete and then they get marked READY. So these instructions will get added last in a celery setup.

I'm not entirely sure why the "AFTER User Task" doesn't show up with celery though. We may be processing too far and not adding it to the db or it's done too fast?

It would be nice if celery worked like non-celery in this regard. Maybe we can lookup waiting subprocesses for instructions as well?

Note: This should NOT be considered a blocker for celery.