search

sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
73 stars 43 forks source link

Call Activity Instance diagram related error #1963

Closed madhurrya closed 2 months ago

madhurrya commented 3 months ago

In the Process instance diagram, when I click on a Call activity which has not completed/started yet and click on 'View Call Activity Diagram' , it gives an error like below saying 'Cannot find a bpmn process with guid '060396db-d2e3-4ac7-81bd-944546f80ac4' for process instance '1238''. Is it because that instance has not started yet so there's no diagram to show yet? If so is that error message meaningful to the user?

Image

Image

jasquat commented 3 months ago

Yeah that makes sense. So the CallActivity Task exists so it has a guid, but that guid isn't linked to a bpmn process yet so we get that error. We probably shouldn't even show that link if the bpmn process doesn't exist yet. As a shortcut we could check status like FUTURE, LIKELY, MAYBE.

madhurrya commented 3 months ago

Now the ' 'View Call Activity Diagram' option is hidden if the Call activity is not active/completed yet.

image

burnettk commented 3 months ago

Yeah, this was the fix we put in.