sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
48 stars 36 forks source link

Requestor and Core Contributor display format should match #696

Open calexh-sar opened 6 months ago

calexh-sar commented 6 months ago

Update PP1 and PP2 so that the Requestor and Core Contributor fields display format matches

(Created from https://www.notion.so/Requestor-and-Core-Contributor-display-format-should-match-8861f71424f14c96bb75f7e709d966a8)

calexh-sar commented 6 months ago

@sashayar13 PP1 and PP2 formats now match. Will be included in next PR for each when you are ready.

sashayar13 commented 6 months ago

@calexh-sar For some reason, I can still see the difference between "Requestor" and "Core Contributor" fields

image

It also looks different at the User Form stage:

image image
sashayar13 commented 6 months ago

@calexh-sar we go with "Requestor" display format

calexh-sar commented 6 months ago

@sashayar13 this is ready for your review again.

sashayar13 commented 6 months ago

@calexh-sar I still see the different formats in PP1 (first user task)

Image

and same in PP2 (first user task) - Requestor and Traveller

calexh-sar commented 6 months ago

@sashayar13 , I updated the cc typeahead on dev to display preferred and last names if preferred is available. Please be aware that the result makes searching for your first and not preferred name appear like this.

Image

sashayar13 commented 6 months ago

@calexh-sar I think there is also a place where the default value is set, and it still uses the old format:

Image

calexh-sar commented 6 months ago

@sashayar13 I am seeing what I posted below. Were you on dev for your post above? If so, which process model?

Image

sashayar13 commented 6 months ago

@calexh-sar yep, it was the Request Goods/Services process model in dev.app

calexh-sar commented 6 months ago

@sashayar13 are you still seeing the wrong format with a new instance there now? I am seeing the updated/requested format.

sashayar13 commented 6 months ago

@calexh-sar yes, I'm still seeing the old format in new instances

calexh-sar commented 6 months ago

@madhurrya what are you seeing in the Core Contributor field on the Submit Details User Task for the Request Goods and Services process on dev.app?

madhurrya commented 6 months ago

@calexh-sar image

calexh-sar commented 6 months ago

@sashayar13 would you pleasae click on the link above, do a hard browser refresh, and let me know what you see then.

sashayar13 commented 6 months ago

@calexh-sar I completed the steps you suggested, but still can see the same

image

I think the reason for this is that this script has not been updated:

image
calexh-sar commented 6 months ago

@sashayar13 good catch, would you please try again and let me now if it correct now.

sashayar13 commented 6 months ago

@calexh-sar yes, the fix helped! Now I can see the matching display formats in PP1. Could you pls apply the same change to PP2?

calexh-sar commented 6 months ago

@dinithihj this should be ready to test on test once PR #880 is merged.

dinithihj commented 5 months ago

Tested and verified on test.app (version 187/189) Both Requestor and Core contributor/Traveller have the same name format.

PP1 image image

PP2 image image

dinithihj commented 5 months ago

Released to Prod on December 21st