sartography / spiff-arena

SpiffWorkflow is a software development platform for building, running, and monitoring executable diagrams
https://www.spiffworkflow.org/
GNU Lesser General Public License v2.1
48 stars 36 forks source link

Git deployment process models issue #766

Open harmeet-status opened 6 months ago

harmeet-status commented 6 months ago

I'm trying to create a PR for Request Travel process (Test -> prod), but instead it creates a PR to merge changes across all process models. See the recording attached.

We will allow the text box to search using a username or a group name.

harmeet-status commented 6 months ago

Video uploaded by @sashayar13:

https://file.notion.so/f/f/1518abd9-c08f-4989-93c1-96525e62bce5/92259964-c88d-4528-b9d9-14f7485f49de/Screen_Recording_2023-10-31_at_3.31.47_PM.mov?id=f43bd1b7-7e4f-49c1-bef1-62e594b474c8&table=block&spaceId=1518abd9-c08f-4989-93c1-96525e62bce5&expirationTimestamp=1701302400000&signature=z3tRqo641cV-JgPOyyKDqbSRVXVkRXfTe9iMeib5LBI&downloadName=Screen+Recording+2023-10-31+at+3.31.47+PM.mov

harmeet-status commented 6 months ago

Comment by @burnettk:

this was occurring because there was an old branch of the travel process model and it wasn’t being updated as a part of the promotion process. we have deleted the branch as a temporary fix and will investigate why it wasn’t being updated.

harmeet-status commented 6 months ago

Comment by @sashayar13:

@burnettk the issue is back, for request goods/services process model (test.app → prod.mod). But this time under branches it shows the correct number of diffs

Image Image

harmeet-status commented 6 months ago

Comment by @burnettk:

please delete the branch from GitHub and then republish from the app.

harmeet-status commented 6 months ago

This issue is not fixed, we are monitoring to see if it comes back.

danfunk commented 5 months ago

Reducing to medium during our monday ticket grooming discussion

harmeet-status commented 5 months ago

@burnettk I think that we have a duplicate, can you close on of these? https://github.com/sartography/spiff-arena/issues/664

burnettk commented 5 months ago

went ahead and closed #664 as a dup, thanks. we updated the branch name to to include the target branch, rather than just the process model identifier. this will resolve this issue, we believe: https://github.com/sartography/spiff-arena/commit/07f2cbc8af9d8154e23eff0f2d3965210dceb043

dinithihj commented 4 months ago

@sashayar13 Can you please let me know if there's anything I should do related to this ticket?

sashayar13 commented 4 months ago

@dinithihj no, I don't think so. We can close the issue

dinithihj commented 4 months ago

Closing ticket as per Sasha's comment.