Events Data Store

[calexh-sar]

Per discussion with @sashayar13 in Discord, create an Events Data Store that is updated in the Create Event Process Model to be used in other processes to display information about the event.

[calexh-sar]

@sashayar13 this is ready for your review and comments.

[madhurrya]

@calexh-sar please see my comments below.

1. When user select an existing event, go to edit page and click "Next", an error displayed in "Purpose" field, saying "Purpose must be string".

2. First select an existing event, go to edit page, change the event name and complete the process. Then start the process again go to even selection dropdown, you will still see the initial event name in the dropdown. But when you go to edit page again you will see the modified name.

3. What is the purpose of the Review page?

4. When you go to edit page the title still shows as "Create a new event", is it better to change this?

[calexh-sar]

@madhurrya please confirm your four comments have been addressed.

[madhurrya]

@calexh-sar all 4 above issues seems to be fixed. But I get an error when creating a new Event. Here are the steps

1. Select "Add new event..." in Select Event Action and submit
2. Add Data and Click "Next" in "Submit Event Details" page
3. Click "Continue" in the "Review" page. You get "Unexpected Workflow Error"

[calexh-sar]

@madhurrya the issue when adding a new event has been fixed.

[madhurrya]

Tested in dev.app

[madhurrya]

@calexh-sar When I click Edit in Review page, in the first form noticing this at the bottom of the page.

[calexh-sar]

@madhurrya is the issue you are pointing out here is the word Create?

[madhurrya]

@calexh-sar the issue is that Task : Submit Event details (Create Event) title and the breadcrumb is coming at the bottom of the page. Instead of at the top of the page.

[calexh-sar]

@madhurrya I just tried to edit an existing event and the header information seemed to be in the correct location. If you are still seeing this, there is nothing I know to do from a process model configuration perspective that would fix this and another ticket should be made for the devs.

[madhurrya]

@calexh-sar This is the issue, please let me know whether I should create a new ticket. https://drive.google.com/file/d/1USAMalxQFcTLdc3nsCsZgsn88GLPMVR7/view?usp=sharing

[calexh-sar]

@madhurrya can you reproduce this issue on a test process? Regardless, another ticket for the devs would be appropriate.

[madhurrya]

@calexh-sar Ok I'll create a ticket for this. Today I noticed a similar thing with this test model. But that is an old model and it was not created using the new form builder. https://dev.app.spiff.status.im/process-models/misc:test:madhu-model-1

[madhurrya]

Created a new ticket for the above issue. https://github.com/sartography/spiff-arena/issues/1175

[madhurrya]

@calexh-sar When I edited some info in an existing Event, I got this error. https://test.app.spiff.status.im/i/3100

Same happens in dev.app also https://dev.app.spiff.status.im/i/3620

[madhurrya]

@sashayar13 should we allow adding multiple events with the same name or should the event name be unique?

[madhurrya]

Noticed that if we use the open quote (the key before the Number 1 key in the keyboard) in both Event name and Purpose, the Review information get messed up. Not sure whether this is something that needs to get fixed.

[calexh-sar]

@sashayar13 is ^ an issue or will the ` character not be used in these cases?

[madhurrya]

Added an Issue for the special character issue, since it is a common issue for all the forms. https://github.com/sartography/spiff-arena/issues/1474

[sashayar13]

@madhurrya Event id should be unique, no restriction for the Event Name yet

[sashayar13]

@calexh-sar @madhurrya I don't expect users will enter ^ into the Name or Purpose. However, I can imagine when a user enters the character ` or uses the breakdown in the Purpose. Suggest the adjustments for this case should be implemented

[calexh-sar]

@sashayar13 regarding the special characters, would you like @madhurrya to put this issue back into 'In Progress' and we will address this as a High Priority or will you be writing up a new issue and prioritizing it accordingly?

[madhurrya]

I have already created a new ticket for the special character issue as it is common for other models also. https://github.com/sartography/spiff-arena/issues/1474 I think Sasha can prioritize it accordingly and better to close this.

[sashayar13]

let's close this one