Open techalchemy opened 6 years ago
FYI I am going to add some tests on top of this and merge it if you don't have any issues, since this makes it a lot easier to test as i mentioned somewhere else
Sure, I probably won’t have much time working on this for the next week, and if I find some I’ll work on creating a better mock PyPI server first.
No worries I don’t think I changed any functionality just moved stuff around. But if you want to release a patch release of master (or I can if you’re ok with it) I can bundle that as the.backup resolver and cut a release of pipenv
models
for most of the Object Oriented stuffoptions
as a central aggregation of options and argument groups - this has 2 classes:Option
andArgumentGroup
, each with the methodadd_to_parser
for ease of userun(self, options)
-- this way we can pass parameters to the correspondingactions
rather than just blanketing the options inLet me know if you have questions or want to change anything here. I tested a bunch of stuff and it seems to work, and (for me anyway) this is starting to make a lot of sense. Happy to work with you to make it clearer, but it's actually a lot easier for me to follow so if it's not too bad for you it'd be super helpful
Here is an example of
cli.add
:and the corresponding
actions.add
This way our core logic isn't tied exclusively to the CLI (and might be accessed by say, pipenv internals someday as a side-benefit)
Here is a new option (from
cli.options
):